0lai0 commented on code in PR #5932:
URL: https://github.com/apache/datafusion-comet/pull/5932#discussion_r4283998992
##########
native/core/src/parquet/eager_page_index_reader_factory.rs:
##########
@@ -646,7 +802,7 @@ impl AsyncFileReader for EagerPageIndexReader {
let metadata = if spark_variant_schema {
with_spark_arrow_schema(metadata)?
} else {
- metadata
+ with_reconciled_variant_markers(metadata)?
Review Comment:
Ohh good catch, and it is worse than you put it: `ignoreVariantAnnotation`
is `!isSpark41Plus || conf`, so every scan below Spark 4.1 paid for a rewrite
whose only consumer never runs. Gated behind `with_reconcile_variant_markers`,
set from `!ignore_variant_annotation`. Nothing else reads the physical side's
marker, and `the_footer_is_left_alone_when_the_annotation_check_is_off` pins
the skip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
