viirya commented on code in PR #7014: URL: https://github.com/apache/datafusion-comet/pull/7014#discussion_r4286190550
########## docs/source/contributor-guide/debugging.md: ########## @@ -254,8 +254,8 @@ so `spark.comet.debug.enabled` and `COMET_LOG_LEVEL` do not affect it. #### Example: dumping window operator output -In `PhysicalPlanner::create_plan` in `native/core/src/execution/planner.rs`, -the `OpStruct::Window` arm builds a `BoundedWindowAggExec` and hands it to +In `WindowBuilder::build` in `native/core/src/execution/planner/window.rs`, +the window operator builds a `BoundedWindowAggExec` and hands it to Review Comment: Since this paragraph now points at `WindowBuilder::build`, could the snippet below it be refreshed as well? The builder picks `window_agg` between `BoundedWindowAggExec` and `WindowAggExec` based on `all_bounded` (`window.rs:134-135`). It then may wrap that in a casting `ProjectionExec` as `final_plan` (`window.rs:155`), and `final_plan` is what goes to `SparkPlan::new`. The example still shows a single `BoundedWindowAggExec::try_new` feeding `SparkPlan::new` directly. That was already stale before this PR, but a reader following the new pointer won't find the lines it describes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
