andygrove commented on PR #7014: URL: https://github.com/apache/datafusion-comet/pull/7014#issuecomment-6202965607
Thanks @kazuyukitanimura and @viirya. Pushed 2c2810750f, which covers the three asks: - `adding_a_new_operator.md`: the "Update the Planner" step now describes writing an `OperatorBuilder` in a module under `planner/`, adding the `OperatorType` variant, mapping the `OpStruct` in `get_operator_type`, and registering it from `register_all_operators`. It no longer tells contributors to add an arm to `create_plan`. - The three `make_all_fields_nullable` comments in `native/common/src/schema.rs` (two) and `planner.rs` now point at `planner/aggregate.rs`. - The window example in `debugging.md` matches `WindowBuilder::build` (see the inline reply). The commit only touches comments and docs, so I did not rerun the test suites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
