andygrove commented on code in PR #7014: URL: https://github.com/apache/datafusion-comet/pull/7014#discussion_r4288616125
########## docs/source/contributor-guide/debugging.md: ########## @@ -254,8 +254,8 @@ so `spark.comet.debug.enabled` and `COMET_LOG_LEVEL` do not affect it. #### Example: dumping window operator output -In `PhysicalPlanner::create_plan` in `native/core/src/execution/planner.rs`, -the `OpStruct::Window` arm builds a `BoundedWindowAggExec` and hands it to +In `WindowBuilder::build` in `native/core/src/execution/planner/window.rs`, +the window operator builds a `BoundedWindowAggExec` and hands it to Review Comment: Good catch. The snippet now shows the `all_bounded` choice between `BoundedWindowAggExec` and `WindowAggExec`, wraps `window_agg` right after it is built (before the casting projection), and says to wrap `final_plan` the same way to see the output after the cast. Pushed in 2c2810750f. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
