github-actions[bot] commented on PR #25279: URL: https://github.com/apache/datafusion/pull/25279#issuecomment-6199189861
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-catalog-listing v55.1.0 (current) Built [ 43.499s] (current) Parsing datafusion-catalog-listing v55.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-catalog-listing v55.1.0 (baseline) Built [ 46.092s] (baseline) Parsing datafusion-catalog-listing v55.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-catalog-listing v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.089s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ListFilesResult.partition_split_points in /home/runner/work/datafusion/datafusion/datafusion/catalog-listing/src/table.rs:72 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 91.345s] datafusion-catalog-listing Building datafusion-datasource v55.1.0 (current) Built [ 46.277s] (current) Parsing datafusion-datasource v55.1.0 (current) Parsed [ 0.038s] (current) Building datafusion-datasource v55.1.0 (baseline) Built [ 47.610s] (baseline) Parsing datafusion-datasource v55.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-datasource v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.273s] 223 checks: 219 pass, 4 fail, 0 warn, 31 skip --- failure function_marked_deprecated: function #[deprecated] added --- Description: A function is now #[deprecated]. Downstream crates will get a compiler warning when using this function. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_marked_deprecated.ron Failed in: function datafusion_datasource::file_scan_config::output_partitioning_from_partition_fields in /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file_scan_config/mod.rs:626 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: ObjectWriterBuilder::with_bytes_written_counter, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/datasource/src/write/mod.rs:214 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_datasource::write::demux::FileMetadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/datasource/src/write/demux.rs:402 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron Failed in: method exact_filter of trait FileSource, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/datasource/src/file.rs:128 Summary semver requires new major version: 3 major and 1 minor checks failed Finished [ 95.452s] datafusion-datasource Building datafusion-physical-plan v55.1.0 (current) Built [ 40.685s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.171s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 40.923s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.186s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.714s] 223 checks: 215 pass, 8 fail, 0 warn, 31 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/auto_trait_impl_removed.ron Failed in: type StatisticsContext is no longer Send, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:131 type StatisticsContext is no longer Sync, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:131 type StatisticsContext is no longer Send, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:131 type StatisticsContext is no longer Sync, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/statistics.rs:131 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_missing.ron Failed in: enum datafusion_physical_plan::joins::utils::ProbeOffset, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/join_hash_map.rs:43 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_physical_plan::proto::registry::register_execution_plan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:150 function datafusion_physical_plan::proto::register_execution_plan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:150 function datafusion_physical_plan::proto::registry::execution_plan_names, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:189 function datafusion_physical_plan::proto::execution_plan_names, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:189 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: ExecutionPlanEncodeCtx::extension_node, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/mod.rs:237 HashJoinExec::prepare_build, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/hash_join/exec/prepared.rs:154 HashJoinExecBuilder::with_prepared_build, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/hash_join/exec/prepared.rs:314 HashJoinExecBuilder::with_null_aware_value_keys, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/hash_join/exec.rs:602 StatisticsContext::compute_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/statistics.rs:304 StatisticsContext::compute_extended_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/statistics.rs:396 StatisticsContext::compute_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/statistics.rs:304 StatisticsContext::compute_extended_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/statistics.rs:396 PartitionedTopKExec::with_ranking_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/sorts/partitioned_topk.rs:284 PartitionedTopKExec::ranking_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/sorts/partitioned_topk.rs:326 ExecutionPlanDecodeCtx::decode_children, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/mod.rs:327 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron Failed in: mod datafusion_physical_plan::joins::key_range_bitmap, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/key_range_bitmap.rs:18 mod datafusion_physical_plan::proto::registry, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:18 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_physical_plan::joins::PreparedHashJoinBuild, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/hash_join/exec/prepared.rs:40 struct datafusion_physical_plan::joins::key_range_bitmap::KeyRangeBitmap, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/key_range_bitmap.rs:52 struct datafusion_physical_plan::TopKDynamicFilters, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/topk/mod.rs:187 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron Failed in: field null_aware_value_keys of struct HashJoinExec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/joins/hash_join/exec.rs:1043 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_missing.ron Failed in: trait datafusion_physical_plan::proto::registry::ExtensionPlanFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:79 trait datafusion_physical_plan::proto::ExtensionPlanFromProto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/physical-plan/src/proto/registry.rs:79 Summary semver requires new major version: 8 major and 0 minor checks failed Finished [ 84.002s] datafusion-physical-plan Building datafusion-proto v55.1.0 (current) Built [ 58.429s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 58.387s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.116s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 118.167s] datafusion-proto Building datafusion-sqllogictest v55.1.0 (current) Built [ 106.171s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 106.779s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.094s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron Failed in: function datafusion_sqllogictest::flush_thread_allocations, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/sqllogictest/src/memory_drift.rs:87 function datafusion_sqllogictest::memory_drift_tracker, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/sqllogictest/src/memory_drift.rs:145 function datafusion_sqllogictest::enable_memory_drift_logging, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/sqllogictest/src/memory_drift.rs:135 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: DataFusionSubstraitRoundTrip::with_optimization, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/sqllogictest/src/engines/datafusion_substrait_roundtrip_engine/runner.rs:60 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_sqllogictest::CountingAllocator, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/16d3ef49db805da97485b28c31b7645a9f9bb467/datafusion/sqllogictest/src/memory_drift.rs:56 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 215.707s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
