alamb commented on code in PR #25562:
URL: https://github.com/apache/datafusion/pull/25562#discussion_r4286986135
##########
datafusion/physical-expr/src/intervals/utils.rs:
##########
@@ -193,3 +197,52 @@ fn interval_dt_to_duration_ms(dt: &IntervalDayTime) ->
Result<i64> {
)
}
}
+
+#[cfg(test)]
+mod tests {
+ use super::*;
+
+ use crate::expressions::{cast, col};
+
+ use arrow::datatypes::{Field, Schema};
+
+ fn int32_schema() -> SchemaRef {
+ Arc::new(Schema::new(vec![Field::new("id", DataType::Int32, false)]))
+ }
+
+ #[test]
+ fn test_check_support_rejects_unsupported_cast_target() -> Result<()> {
Review Comment:
do we need the rust tests given we also have .slt coverage? I feel like the
.slt coverage is adequate and the rust tests are redundant 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
