shoemoney commented on PR #25562: URL: https://github.com/apache/datafusion/pull/25562#issuecomment-6206568699
@alamb Good call — removed the Rust unit tests in af34fa9. The nested-cast case they covered (unsupported type in the middle of a chain) is already exercised end-to-end by the slt: the view casts id to VARCHAR and the filter casts back to INT, so the physical plan hits exactly that path. Also added the selective `CAST(id AS INT) > 5` case @kosiew suggested. Thanks both for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
