goldmedal commented on code in PR #12263:
URL: https://github.com/apache/datafusion/pull/12263#discussion_r1741091339
##########
datafusion/core/src/datasource/physical_plan/csv.rs:
##########
@@ -112,6 +114,7 @@ impl CsvExecBuilder {
has_header: false,
delimiter: b',',
quote: b'"',
+ terminator: None,
Review Comment:
I did some tests. I think that `newlines_in_values` won't be impacted by
`terminator`. No matter how I change the terminator, the number of rows is the
same.
```rust
let session_ctx = SessionContext::new();
let store = object_store::memory::InMemory::new();
let data = bytes::Bytes::from("a,b\r1,\"2\na\"\r3,\"4\nb\"");
let path = object_store::path::Path::from("a.csv");
store.put(&path, data.into()).await.unwrap();
let url = Url::parse("memory://").unwrap();
session_ctx.register_object_store(&url, Arc::new(store));
let df = session_ctx
.read_csv("memory:///",
CsvReadOptions::new().newlines_in_values(true).terminator(Some(b'\r')))
.await
.unwrap();
let result = df.collect().await.unwrap();
assert_eq!(result[0].num_rows(), 2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
