korowa commented on code in PR #12263:
URL: https://github.com/apache/datafusion/pull/12263#discussion_r1741148011
##########
datafusion/core/src/datasource/physical_plan/csv.rs:
##########
@@ -1210,6 +1244,44 @@ mod tests {
crate::assert_batches_eq!(expected, &result);
}
+ #[tokio::test]
+ async fn test_terminator() {
Review Comment:
Yes, it works only for single character -- probably ConfigField
[implementation](https://github.com/apache/datafusion/blob/ac74cd3163e43563807a8c6e8e72bb058cb6f459/datafusion/common/src/config.rs#L983)
for u8 should be enhanced, as right now it doesn't accept escape sequences
like `\t` `\n` etc.
(same works for the delitmiter -- I was'n able to read tab-separated file
via SQL :thinking: )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
