goldmedal commented on code in PR #12263:
URL: https://github.com/apache/datafusion/pull/12263#discussion_r1742412198
##########
datafusion/sqllogictest/test_files/csv_files.slt:
##########
@@ -336,3 +336,23 @@ id message
05)good test
4 unquoted
value end
+
+statement ok
+CREATE EXTERNAL TABLE stored_table_with_cr_terminator (
+col1 TEXT,
+col2 TEXT
+) STORED AS CSV
+LOCATION '../core/tests/data/cr_terminator.csv'
+OPTIONS ('format.terminator' E'\r', 'format.has_header' 'true');
+
+# TODO: It should be passed but got the error: External error: query failed:
DataFusion error: Object Store error: Generic LocalFileSystem error: Requested
range was invalid
+# query TT
+# select * from stored_table_with_cr_terminator;
Review Comment:
I still got this error in the sqllogictests but I don't know why. The same
case in
[datafusion/core/src/datasource/physical_plan/csv.rs](https://github.com/apache/datafusion/pull/12263/files#diff-264e8b6a69a6d6132ac5bf88de1e27a8539b6840619c4d51d2c0c8426cc79612)
works fine. I tried to find if there are any special configs for object_store
in the sqllogictests but I found nothing. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
