jayzhan211 commented on code in PR #12296:
URL: https://github.com/apache/datafusion/pull/12296#discussion_r1741296984
##########
datafusion/expr/src/udaf.rs:
##########
@@ -262,6 +262,19 @@ impl AggregateUDF {
self.inner.is_descending()
}
+ /// Returns true if the function is min. Used by the optimizer
+ pub fn is_min(&self) -> bool {
Review Comment:
This is not we should do...
We need to understand the context and have a general function instead of a
specialize name matching function.
`default_value` is a good example, it is only used in count for now, but it
could extend to any function if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
