edmondop commented on code in PR #12296:
URL: https://github.com/apache/datafusion/pull/12296#discussion_r1742054100
##########
datafusion/expr/src/udaf.rs:
##########
@@ -262,6 +262,19 @@ impl AggregateUDF {
self.inner.is_descending()
}
+ /// Returns true if the function is min. Used by the optimizer
+ pub fn is_min(&self) -> bool {
Review Comment:
@jayzhan211 looking to this comment from @alamb
https://github.com/apache/datafusion/issues/11151#issuecomment-2198513514 it
might be that those "general functions" might not exists, will do some homework
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
