edmondop commented on PR #12296: URL: https://github.com/apache/datafusion/pull/12296#issuecomment-2350703351
> Thanks @edmondop and @jayzhan211 - I have a suggestion about how to proceed. Let me know if that makes sense > > Sorry (again) for the delay I tried to implement that solution, but the problem is now here https://github.com/apache/datafusion/pull/12296/files#diff-bca16ed42e39a82d942b706ad36b0d49502c12c9bc1c50e33ed443ce8c4d0437 that there is no real distinction between count and min_max. So the non distinct count doesn't get taken at line 61 but only at line https://github.com/apache/datafusion/pull/12296/files#diff-bca16ed42e39a82d942b706ad36b0d49502c12c9bc1c50e33ed443ce8c4d0437R65 We have two options imho: - passing distinct to get_value from stats - have a separate method for count? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
