andygrove commented on code in PR #7096:
URL: https://github.com/apache/datafusion-comet/pull/7096#discussion_r4338748172
##########
spark/src/main/scala/org/apache/spark/Plugins.scala:
##########
@@ -322,7 +322,7 @@ object CometDriverPlugin extends Logging {
// spark.comet.exec.memoryPool.fraction was documented as holding back part
of the off-heap pool
// for the native memory that Comet does not reserve. It cannot: Spark hands
out the whole pool
- // to the tasks that ask for it, and the fraction only caps each task's
consumers under
+ // to the tasks that ask for it, and the fraction only limits the operators
that can spill under
Review Comment:
Fixed in 6a1c4dffca, using your wording: the comment now says the fraction
only caps each task's total under fair_unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
