andygrove commented on code in PR #7096: URL: https://github.com/apache/datafusion-comet/pull/7096#discussion_r4338748585
########## native/core/src/execution/memory_pools/fair_pool.rs: ########## @@ -31,14 +32,31 @@ use parking_lot::Mutex; /// A DataFusion fair `MemoryPool` implementation for Comet. Internally this is /// implemented via delegating calls to [`crate::jvm_bridge::CometTaskMemoryManager`]. +/// +/// Spark limits each task to an even share of its off-heap pool among the tasks that hold memory +/// from it, and it cannot ask a native consumer to spill. So, as DataFusion's `FairSpillPool` does +/// over its whole pool, this pool limits each consumer that can spill to an even share of what the Review Comment: Done in 6a1c4dffca. The doc comment on `CometFairMemoryPool` and the guide both give `task_share` and `limit` as a formula block, with the prose reduced to defining the terms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
