Smallfu666 commented on PR #5982: URL: https://github.com/apache/datafusion-comet/pull/5982#issuecomment-6383627616
Thanks for the review! 1. Switched to `ScalarValue::min` and removed the helper. 2. Merged the `Int32` cases into one table-driven test. 3. Removed the decimal test and moved its range assertion into the other decimal test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
