Smallfu666 commented on PR #6179: URL: https://github.com/apache/datafusion-comet/pull/6179#issuecomment-6383627408
Thanks, good idea! Moved the check into `getSupportLevel` with `canProduceNullMapKey` and dropped the new arm. The test now also covers an earlier `Incompatible` struct field. #6200 itself still applies to other casts. The other `isSupported` callers are `GenerateDocs` (primitive types only) and `CometToPrettyString` (casts to string), so neither can hit a map to map cast. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
