alamb commented on PR #12383: URL: https://github.com/apache/datafusion/pull/12383#issuecomment-2338109634
> Thanks for correcting my mistakes. I really appreciate it! I'll be more careful with my code next time. Agreed -- thanks @2010YOUY01 (and sorry I didn't catch this in review either) In general I wonder if there is a better way to test the string functions (since many of them now have multiple implementations for different input type combinations, but each implementation should get the same answer) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
