alamb commented on PR #12383: URL: https://github.com/apache/datafusion/pull/12383#issuecomment-2340298829
> One thing to do is to duplicate existing SQL test cases and convert StringArray columns to StringView columns, I think not every PR for string function native StringView support did this 🤔 > I can do a sample PR and open several issues for string functions missing StringView SQL level tests Thanks @2010YOUY01 The potential downside of doing that is that it will not evolve as we add new string functions (e.g. we add a new string function that doesn't handle StringView, how will we know?) I wonder if we can potentially do something more automated like have the same queries and expected files and run them against different test cases. I think we could do this in sqllogictest by separating the table definitions into different .slt files and then `include`ing the same queries file. Here is an example: https://github.com/apache/datafusion/blob/02eab80cd62e02fcb68dee8b99d63aaac680a66c/datafusion/sqllogictest/test_files/join_disable_repartition_joins.slt#L26-L25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
