alexanderbianchi commented on code in PR #26603:
URL: https://github.com/apache/datafusion/pull/26603#discussion_r4413305891
##########
datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:
##########
@@ -215,6 +215,24 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
from_substrait_rel(self, rel).await
}
+ /// Consumes independent inputs of a JOIN or UNION, returning plans in
input order.
+ ///
+ /// Implementations must return exactly one plan per input, in the same
order.
+ /// On error, implementations must drop any unfinished input futures.
+ ///
+ /// The default preserves sequential consumption. Implementations may
override it
+ /// when they can isolate mutable traversal state between inputs.
+ async fn consume_rel_inputs(
Review Comment:
Updated the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
