alexanderbianchi commented on code in PR #26603:
URL: https://github.com/apache/datafusion/pull/26603#discussion_r4413464964
##########
datafusion/substrait/src/logical_plan/consumer/rel/join_rel.rs:
##########
@@ -33,12 +36,20 @@ pub async fn from_join_rel(
return not_impl_err!("JoinRel with post_join_filter is not yet
supported");
}
- let left: LogicalPlanBuilder = LogicalPlanBuilder::from(
- consumer.consume_rel(join.left.as_ref().unwrap()).await?,
- );
- let right = LogicalPlanBuilder::from(
- consumer.consume_rel(join.right.as_ref().unwrap()).await?,
- );
+ let (Some(left), Some(right)) = (join.left.as_deref(),
join.right.as_deref()) else {
+ return substrait_err!("JoinRel requires left and right inputs");
+ };
+ let [left, right] = consumer
+ .consume_rel_inputs(&[left, right])
Review Comment:
Lambda state:
- [The RwLock and parameter
stack](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L734-L744).
- [Mutation through &self: acquire the write lock and push
parameters](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L763-L792).
- [The sequence spanning an await: push → consume body →
pop](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/expr/lambda.rs#L35-L43).
Correlated-subquery state:
- [The outer_schemas
lock](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L598-L602)
and [push/pop mutations through
&self](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L636-L642).
- [The sequence spanning an await: push → consume subquery →
pop](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/expr/subquery.rs#L35-L43).
##########
datafusion/substrait/src/logical_plan/consumer/rel/join_rel.rs:
##########
@@ -33,12 +36,20 @@ pub async fn from_join_rel(
return not_impl_err!("JoinRel with post_join_filter is not yet
supported");
}
- let left: LogicalPlanBuilder = LogicalPlanBuilder::from(
- consumer.consume_rel(join.left.as_ref().unwrap()).await?,
- );
- let right = LogicalPlanBuilder::from(
- consumer.consume_rel(join.right.as_ref().unwrap()).await?,
- );
+ let (Some(left), Some(right)) = (join.left.as_deref(),
join.right.as_deref()) else {
+ return substrait_err!("JoinRel requires left and right inputs");
+ };
+ let [left, right] = consumer
+ .consume_rel_inputs(&[left, right])
Review Comment:
Lambda state:
- [The RwLock and parameter
stack](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L734-L744).
- [Mutation through &self: acquire the write lock and push
parameters](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L763-L792).
- [The sequence spanning an await: push → consume body →
pop](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/expr/lambda.rs#L35-L43).
Correlated-subquery state:
- [The outer_schemas
lock](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L598-L602)
and [push/pop mutations through
&self](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs#L636-L642).
- [The sequence spanning an await: push → consume subquery →
pop](https://github.com/apache/datafusion/blob/ccbcea562b3c8112760e67ba8a65d237b2037e7c/datafusion/substrait/src/logical_plan/consumer/expr/subquery.rs#L35-L43).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
