laxmanmamididd commented on PR #7449: URL: https://github.com/apache/datafusion-comet/pull/7449#issuecomment-6617440438
Thanks, both. I've updated the description: - It closes #2717, with a note that #2718 only changed the error and that the bug dates from 0.12.0. - It carries `(cherry picked from commit 070951d2a77fbaa597056d8de48d29812b10f2e5)`, noting that only the `literals.scala` lines are taken. Whoever squashes can keep that line in the commit message. I can also amend the branch commit to carry it if you'd rather the trailer be there before merge. - `branch-1.0` has the same two `.array` calls at lines 103 and 211, so it fails the same way. I can open a backport if 1.0 is still taking patch releases. @comphead, on moving the test to `sequence.sql`: on `branch-1.1`, `CometSqlFileTestSuite` always appends `ConstantFolding` to the excluded rules (`constantFoldingExcluded`, after `file.configs`). A file can't turn folding back on, because `-- ConstantFolding: enabled` only exists on `main`. `sequence(1, 5)` would then reach Comet as a `Sequence` expression, not an `UnsafeArrayData` literal, so the query would pass with or without the fix. Reading `i_start` has the same problem, because `sequence(i_start, ...)` over a column is never folded into a literal. That's why the test stays in `CometArrayExpressionSuite`, where folding runs. Happy to move it if you'd prefer to backport the `ConstantFolding: enabled` directive first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
