laxmanmamididd commented on code in PR #7449:
URL: https://github.com/apache/datafusion-comet/pull/7449#discussion_r4475645661
##########
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##########
@@ -495,6 +495,24 @@ class CometArrayExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelp
}
}
+ test("folded array literals backed by UnsafeArrayData") {
Review Comment:
Answered in
https://github.com/apache/datafusion-comet/pull/7449#issuecomment-6617440438.
On `branch-1.1`, `CometSqlFileTestSuite` always excludes `ConstantFolding`, so
in `sequence.sql` `sequence(1, 5)` would reach Comet as a `Sequence` expression
and never as the folded `UnsafeArrayData` literal. The query would pass with or
without the fix. That's why the test stays in `CometArrayExpressionSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
