devtechedge commented on PR #2618: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2618#issuecomment-6620756601
You were right about the span, and I appreciate you taking the time to point at the exact columns. 👍 Both points are addressed in commit 006a5592. The span point is a real bug, and the test point is the coverage that should have come with it. The language name now runs from the start of the token to the opening quote, so `get_source` returns `N`, and the code block picks up at the quote. The span test covers both halves, with one assertion for `N` and one for the literal. I checked the new assertion against the previous commit first, and it fails there, so the test pins the split rather than only passing with the fix. The formatting check, clippy with `-D warnings`, and the full test suite all pass on the commit. I am happy to reshape the offset or the test if you had something else in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
