shrivasshankar commented on code in PR #27148:
URL: https://github.com/apache/datafusion/pull/27148#discussion_r4516394149
##########
datafusion/physical-expr/src/intervals/utils.rs:
##########
@@ -44,9 +82,10 @@ pub fn check_support(expr: &Arc<dyn PhysicalExpr>, schema:
&SchemaRef) -> bool {
// interval endpoints to a type with a different ordering (e.g.
integers
// to strings) does not preserve the interval, so such expressions are
// left unanalyzed rather than producing bogus bounds.
- is_datatype_supported(cast.cast_type()) && check_support(cast.expr(),
schema)
+ is_type_supported(cast.cast_type())
Review Comment:
I added only in check_statistics_support though, since the SHJ sanity
checker uses check_support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
