shrivasshankar commented on PR #27148: URL: https://github.com/apache/datafusion/pull/27148#issuecomment-6754650695
> Thanks @shrivasshankar, this addresses all my comments. > > As the fix now applies to every type, the title and description should say it's no longer decimal-only: filters on `count(*)`/`rank()` outputs now get the default selectivity too, which is what changes TPC-DS q8, q34, q70 and q73. > > For the same reason, the automated benchmarks @devanbenz asked for matter even more now. The local SF1 runs look good, but I would wait for them before merging. Thanks! Updated the title and description to make it clear it now applies to every type. Agreed, happy to wait for the benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
