Pastoray commented on PR #27273:
URL: https://github.com/apache/datafusion/pull/27273#issuecomment-6837844911

   > Follow-up to the heads-up above: the `datafusion-spark` crate now lives in 
https://github.com/apache/datafusion-spark, and that repo is ready to accept 
PRs.
   > 
   > If this PR changes `datafusion-spark` files, please open a new PR with 
those changes against apache/datafusion-spark. Before opening it, please read 
the [contributing 
guide](https://github.com/apache/datafusion-spark/blob/main/CONTRIBUTING.md). 
Any changes to other DataFusion crates stay in this PR. Thanks!
   
   Thanks. The encode change depends on two new `datafusion.spark.*` options 
defined in datafusion common. How should that be handled ? should i land the 
options here and port `encode.rs` / `encode.slt` once datafusion spark builds 
against a core that has them, or will those options live in the new repo ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to