Perseus commented on code in PR #106:
URL: 
https://github.com/apache/datafusion-iceberg/pull/106#discussion_r4563745353


##########
crates/datafusion/src/read/scan.rs:
##########
@@ -51,6 +54,9 @@ pub struct IcebergDataSource {
     projection: Vec<String>,
     /// Filter to apply to the table scan
     predicate: Option<Predicate>,
+    /// Physical filters pushed down by DataFusion. The scan ANDs the parts 
that convert
+    /// to an Iceberg predicate onto `predicate`.
+    filters: Vec<Arc<dyn PhysicalExpr>>,

Review Comment:
   `filters` stores both static and dynamic filters
   
   Static filters are already converted and stored in the `predicate` field at 
scan time, but dynamic filters can't be converted that way; so we need to store 
the raw filters here, even though it has redundant copies of the static filters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to