alexanderbianchi commented on code in PR #106:
URL: 
https://github.com/apache/datafusion-iceberg/pull/106#discussion_r4607303937


##########
crates/datafusion/tests/integration_datafusion_test.rs:
##########
@@ -1205,6 +1208,55 @@ async fn test_plan_nodes_are_inspectable() -> Result<(), 
Box<dyn Error>> {
     Ok(())
 }
 
+/// A scan keeps the filters DataFusion pushes into it and reads only the rows 
that
+/// match them. It reports each filter as not pushed down, so DataFusion still
+/// applies it.
+#[tokio::test]
+async fn test_scan_applies_pushed_filters() -> Result<(), Box<dyn Error>> {
+    let iceberg_catalog = get_iceberg_catalog().await;
+    let namespace = NamespaceIdent::new("test_pushed_filters".to_string());
+    set_test_namespace(&iceberg_catalog, &namespace).await?;
+    let creation = get_table_creation(temp_path(), "my_table", None)?;
+    iceberg_catalog.create_table(&namespace, creation).await?;
+
+    let ctx = SessionContext::new();
+    let catalog = 
IcebergCatalogProvider::try_new(Arc::new(iceberg_catalog)).await?;
+    ctx.register_catalog("catalog", Arc::new(catalog));

Review Comment:
   Could you use the taxi dataset instead of doing an insert?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to