comphead commented on code in PR #7356:
URL: https://github.com/apache/datafusion-comet/pull/7356#discussion_r4565890540


##########
Makefile:
##########
@@ -22,6 +22,11 @@ $(shell ./mvnw help:evaluate -q -DforceStdout 
-Dexpression=extraJavaTestArgs $(P
 endef
 
 # Build optional Comet native features (like hdfs-opendal e.g)
+comma := ,
+# The jemalloc Maven profile also builds the native library with the jemalloc 
allocator
+ifneq (,$(findstring jemalloc,$(PROFILES)))
+override COMET_FEATURES := $(if 
$(COMET_FEATURES),$(COMET_FEATURES)$(comma))jemalloc

Review Comment:
   The Makefile now stops with an error when `-Pjemalloc` is combined with 
`COMET_FEATURES` naming `mimalloc`. The test and the INFO line are gone, so 
nothing reports an allocator from the `jemalloc` feature flag anymore.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to