comphead commented on PR #7356:
URL: 
https://github.com/apache/datafusion-comet/pull/7356#issuecomment-6881627275

   Thanks @dwsmith1983. Both points are addressed in 6daaacf724.
   
   - **`memory.md`.** It now says that in a `jemalloc` or `mimalloc` build "the 
Rust allocations in Comet's native library" do not come from glibc. It adds 
that C code such as zstd and the JVM still allocate through glibc, so trimming 
still helps with that memory.
   - **Conflicting allocator features.** The Makefile check now looks at the 
final feature list instead of the profile. `make release 
COMET_FEATURES=mimalloc,jemalloc` stops with the same error as `-Pjemalloc` 
plus `mimalloc`. I left `lib.rs` alone. Its three cfgs were written in #5934 to 
cover every feature combination, with "both" mapped to the system allocator on 
purpose. A `compile_error!` there would also break `cargo build --all-features` 
and `cargo clippy --all-features`, which people run locally. That changes the 
native crate's behavior for every build, not just the profile, so I'd rather 
keep it out of this docs-and-profile PR. Happy to open an issue for it if you 
think it's worth it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to