AdamGS commented on code in PR #27380:
URL: https://github.com/apache/datafusion/pull/27380#discussion_r4589542902


##########
datafusion/expr/src/test/function_stub.rs:
##########
@@ -229,7 +229,7 @@ impl Count {
 
 impl AggregateUDFImpl for Count {
     fn name(&self) -> &str {
-        "COUNT"

Review Comment:
   makes the stub get treated the same way as the original func, as some code 
paths check for the exact name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to