andygrove commented on code in PR #27428:
URL: https://github.com/apache/datafusion/pull/27428#discussion_r4600224270


##########
datafusion/ffi/src/physical_expr/mod.rs:
##########
@@ -395,6 +399,15 @@ unsafe extern "C" fn hash_fn_wrapper(expr: 
&FFI_PhysicalExpr) -> u64 {
     hasher.finish()
 }
 
+unsafe extern "C" fn eq_fn_wrapper(

Review Comment:
   Added `test_ffi_physical_expr_eq_across_library_images` in 0150c0f82. It 
loads two copies with `get_module_copy` and asserts that the same `Column` from 
each copy compares unequal, while two from the same copy compare equal. I 
confirmed it fails with the marker check removed.



##########
docs/source/library-user-guide/upgrading/57.0.0.md:
##########
@@ -97,3 +97,21 @@ that aligns with the SQL specification.
 ```txt
 COPY (SELECT * FROM t ORDER BY c1) TO 'ordered.parquet';
 ```
+
+### `FFI_ExecutionPlan` carries input requirements

Review Comment:
   Moved to `56.0.0.md` in 0150c0f82, so main and `branch-56` agree.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to