notfilippo commented on code in PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#discussion_r1765157634
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +89,94 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
+}
+
+#[derive(Clone, Debug)]
+pub struct Scalar {
+ value: ScalarValue,
+ data_type: DataType,
+}
Review Comment:
I was thinking that I could open a new PR introducing just introducing this
columnar value type, and then little by little removing the scalar value
variants (Dictionary, Large* and *View...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
