alamb commented on code in PR #11978:
URL: https://github.com/apache/datafusion/pull/11978#discussion_r1765286489
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +89,94 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
+}
+
+#[derive(Clone, Debug)]
+pub struct Scalar {
+ value: ScalarValue,
+ data_type: DataType,
+}
Review Comment:
I agree with @findepi 's suggestion to make the smallest PR as possible to
begin. I think splitting this PR out into a small part to begin, along with
comments explaining the planned end state (or linking back to the ticket that
describes this) would be very helpful
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +89,94 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
+}
+
+#[derive(Clone, Debug)]
+pub struct Scalar {
+ value: ScalarValue,
+ data_type: DataType,
+}
Review Comment:
I agree with @findepi 's suggestion to make the smallest PR as possible to
begin. I think splitting this PR out into a small part to begin, along with
comments explaining the planned end state (or linking back to the ticket that
describes this) would be very helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
