paleolimbot commented on code in PR #27383:
URL: https://github.com/apache/datafusion/pull/27383#discussion_r4602562026
##########
datafusion/common/src/nested_struct.rs:
##########
@@ -570,7 +694,9 @@ fn cast_map_column(
target_entries,
target_sorted,
None,
+ cast_extension,
)?;
+ let (source_key, source_value) =
validate_map_entries_field(source_entries)?;
Review Comment:
As I understand it this is already validated as part of the map cast
validation but conslidating the logic is an invasive change and this additional
validation is cheap. I can try harder to consolidate the two pieces of logic if
this is important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]