paleolimbot commented on PR #27383: URL: https://github.com/apache/datafusion/pull/27383#issuecomment-6954504050
> Ok so this would work only with an DFCastOptions This seemed like a nice change, particularly since we're introducing a new function, so I went with it. Happy to do whatever here. > Do you think we can avoid having two casting functions? I hope so. I went with a new function name to avoid breaking things, but we could deprecate the old function too. > For example, how would we do overrides with the current system? I believe Spark compatibility needs these types of overrides. DataFusion itself overrides some types of casting, too (e.g., structs) if this approach is ever upstreamed into arrow-cast. It's an open question how to design the registry to handle conflicts (last registered wins vs. never dispatch if multiple registrations match vs. require a declaration on register and hash the input and output types). > I think having an end to end prototype of a casting registry would be a good thing to have before committing in on a design. That's a great point...I'll add it to this PR and we can take it out if it turns out it's something we agree should be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
