jonahgao commented on code in PR #12467: URL: https://github.com/apache/datafusion/pull/12467#discussion_r1765352344
########## datafusion/common/src/dfschema.rs: ########## @@ -412,17 +412,32 @@ impl DFSchema { } } + /// Check whether the column reference is ambiguous + pub fn check_ambiguous_name( Review Comment: It looks like we no longer need to add these two functions🤔, `qualified_field_with_qualified_name` and `qualified_fields_with_qualified_name`, along with the modifications to `qualified_field_with_name` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org