HuSen8891 commented on code in PR #12467: URL: https://github.com/apache/datafusion/pull/12467#discussion_r1766014142
########## datafusion/common/src/dfschema.rs: ########## @@ -412,17 +412,32 @@ impl DFSchema { } } + /// Check whether the column reference is ambiguous + pub fn check_ambiguous_name( Review Comment: These two functions will check the ambiguous column reference, it's necessary, or we could not identify the case below: create table t1(v1 int); select count(*) from t1 right outer join t1 on t1.v1 > 0; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org