jonahgao commented on PR #12467: URL: https://github.com/apache/datafusion/pull/12467#issuecomment-2360168792
We may check ambiguous names during `search_dfschema` to achieve one pass search. However, before doing this, it would be better to remove the following logic; otherwise, the code in `dfschema.rs` will become too redundant. https://github.com/apache/datafusion/blob/eaf8d162ca3dcfa4a0abe9d77b660cdf1433373c/datafusion/common/src/dfschema.rs#L358-L369 On the other hand, having a separate `check_ambiguous_name` in the current implementation would be clearer. Let's merge it first, and then explore other optimization possibilities later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
