coderfender commented on code in PR #2868:
URL: 
https://github.com/apache/datafusion-ballista/pull/2868#discussion_r4646798524


##########
ballista/core/src/hll.rs:
##########
@@ -15,47 +15,47 @@
 // specific language governing permissions and limitations
 // under the License.
 
-//! HyperLogLog distinct-count sketch for shuffle output columns.
+//! HyperLogLog distinct-count sketch for shuffle output columns, backed by the
+//! Apache DataSketches HLL sketch.
 //!
-//! Shuffle writers update one sketch per sketched column, executors ship the
-//! registers to the scheduler in `TaskColumnStats.sketches`, and the scheduler
-//! merges every task's sketch for a column into a stage-level distinct count.
+//! Shuffle writers update one sketch per sketched column, executors ship it to
+//! the scheduler in `TaskColumnStats.sketches`, and the scheduler merges every
+//! task's sketch for a column into a stage-level distinct count with a
+//! [`HyperLogLogUnion`].

Review Comment:
   Thank you. I fixed the doc issue. Please take a look whenever you can



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to