coderfender commented on PR #2868:
URL: 
https://github.com/apache/datafusion-ballista/pull/2868#issuecomment-6959022211

   TPC-H SF10, local cluster (1 scheduler, 2 executors, 18 cores), 3 
iterations, minimum per query in seconds:
   
   | Query | `collect_distinct_counts=false` | `main` (74c09243) | this PR | PR 
vs `main` |
   |---|---|---|---|---|
   | q1 | 0.292 | 0.276 | 0.277 | +0.2% |
   | q2 | 0.097 | 0.091 | 0.086 | -5.4% |
   | q3 | 0.200 | 0.182 | 0.185 | +1.5% |
   | q4 | 0.194 | 0.170 | 0.175 | +2.7% |
   | q5 | 0.242 | 0.257 | 0.253 | -1.5% |
   | q6 | 0.101 | 0.098 | 0.099 | +0.4% |
   | q7 | 0.569 | 0.577 | 0.596 | +3.2% |
   | q8 | 0.284 | 0.289 | 0.285 | -1.6% |
   | q9 | 0.584 | 0.582 | 0.619 | +6.4% |
   | q10 | 0.375 | 0.360 | 0.394 | +9.5% |
   | q11 | 0.055 | 0.066 | 0.053 | -20.0% |
   | q12 | 0.233 | 0.234 | 0.237 | +1.2% |
   | q13 | 0.300 | 0.297 | 0.308 | +3.5% |
   | q14 | 0.133 | 0.136 | 0.137 | +0.5% |
   | q15 | 0.228 | 0.229 | 0.231 | +0.7% |
   | q16 | 0.094 | 0.094 | 0.099 | +4.6% |
   | q17 | 0.953 | 0.856 | 0.769 | -10.2% |
   | q18 | 1.326 | 1.423 | 1.214 | -14.7% |
   | q19 | 0.257 | 0.248 | 0.253 | +1.9% |
   | q20 | 0.359 | 0.392 | 0.380 | -3.1% |
   | q21 | 0.955 | 0.899 | 0.874 | -2.7% |
   | q22 | 0.132 | 0.130 | 0.129 | -0.9% |
   | **Total** | **7.96** | **7.89** | **7.65** | **-3.0%** |
   
   Per-query differences are within about ±10% run-to-run noise in both 
directions, and turning the sketches off isn't faster than either 
implementation. The extra hash per value is real but doesn't show end to end at 
this scale. I'll raise a `Coupon::from_hash` constructor upstream so the second 
hash can be dropped.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to