haziqishere commented on code in PR #7704:
URL: https://github.com/apache/datafusion-comet/pull/7704#discussion_r4652353006


##########
spark/src/main/scala/org/apache/comet/rules/EliminateRedundantTransitions.scala:
##########
@@ -176,6 +176,15 @@ case class EliminateRedundantTransitions(session: 
SparkSession)
             CometColumnarShuffle,
             _) =>
         s.withNewChildren(Seq(child))
+
+      // Spark also adds `RowToColumnar` even when comet chose native shuffle.
+      // Native shuffle reads only Comet vectors, not Spark's vectors.
+      // Switch to row and drop the transition.

Review Comment:
   My bad, I reworded the comment in 7f688f349. Added the case to the 
input-contract paragraph in `native_shuffle.md` and as item 5 under "When JVM 
Shuffle is Used" in `jvm_shuffle.md` in d11d43931.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to