haziqishere commented on code in PR #7704:
URL: https://github.com/apache/datafusion-comet/pull/7704#discussion_r4652366359


##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -575,6 +575,15 @@ object CometShuffleExchangeExec
       nativeShuffleFailureReasons(s).isEmpty &&
       !hashesDifferentlyFromSpark(s)
 
+  /**
+   * Whether the JVM columnar shuffle can take `s` with `rowChild`, a 
row-based plan, as its
+   * child. Pure: does not tag the node
+   */
+  def columnarShuffleSupports(s: CometShuffleExchangeExec, rowChild: 
SparkPlan): Boolean =
+    !isCometCelebornShuffleManagerEnabled(s.conf) &&
+      columnarShuffleFailureReasons(
+        ShuffleExchangeExec(s.outputPartitioning, rowChild, 
s.shuffleOrigin)).isEmpty

Review Comment:
   I do agree with you. Its quite redundant as under Celeborn the exchange only 
accept Comet native mode. Dropped it in 62e53a309. I kept the check in the new 
`isNativeConversionSupported`, where nothing else excludes Celeborn.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to