haziqishere commented on PR #7704:
URL: 
https://github.com/apache/datafusion-comet/pull/7704#issuecomment-7062472786

   @comphead Thanks for reviewing the changes! I did make amendments based on 
your review.
   
   Quick questions:
   
   1. The fallback keeps native shuffle, so a string hash key is placed by 
native shuffle reading converted rows. I didn't apply 
`hashesDifferentlyFromSpark` because Comet had already chosen native shuffle 
for this exchange. Does that hold, or should the fallback decline string keys 
too?
   
   2. Fork CI is enabled and running on the latest head. Could you help to add 
a `run-spark-*` label for the Spark SQL verdict? I can't apply labels from the 
fork.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to