alamb commented on code in PR #12536: URL: https://github.com/apache/datafusion/pull/12536#discussion_r1774084233
########## datafusion/expr-common/src/scalar.rs: ########## @@ -0,0 +1,146 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::{ + array::{Array, ArrayRef}, + datatypes::DataType, +}; +use datafusion_common::{exec_err, DataFusionError, Result, ScalarValue}; + +/// Represents a physical scalar value obtained after evaluating an expression. +/// +/// Currently [`Scalar`] represents a no-op wrapper around scalar value. This +/// is due to the fact that the current variants of [`ScalarValue`] correspond +/// 1:1 with the variants of [`DataType`]. The goal of this type is aid the +/// process of condensing some of the variants (e.g. [`ScalarValue::LargeUtf8`], +/// [`ScalarValue::Utf8View`], and [`ScalarValue::Utf8`]) into a single variant +/// (e.g. [`ScalarValue::Utf8`]). This type achieves this goal by storing the +/// physical type as [`DataType`] alongside the value represented as +/// [`ScalarValue`]. +/// +/// [`Scalar`] cannot be constructed directly as not all [`DataType`] variants Review Comment: I don't think this is intentional (that some types can not be handled) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
