findepi commented on code in PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#discussion_r1771799372
##########
datafusion/expr-common/src/columnar_value.rs:
##########
@@ -89,7 +91,7 @@ pub enum ColumnarValue {
/// Array of values
Array(ArrayRef),
/// A single value
- Scalar(ScalarValue),
+ Scalar(Scalar),
Review Comment:
> The end state in my mind is that,
> `ColumnarValue` stores `ArrayRef` for multiple rows and `ScalarValue` for
single rows case. `ScalarValue` has either native type like `i64` or
`arrow::Scalar`.
Ok, so `ScalarValue` is going to be physical and also going to be simplified.
what will be used in `Expr::Literal`?
i am very interested in this part
> `ScalarValue::String` is then something close to `logical type`
but being used in very physical context, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
