hailelagi commented on code in PR #12561:
URL: https://github.com/apache/datafusion/pull/12561#discussion_r1779289298
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -1386,6 +1388,7 @@ impl AsLogicalPlan for LogicalPlanNode {
options,
constraints,
column_defaults,
+ ..
Review Comment:
here i am undecided about how to handle the flag, if so it would have to be
serialised with `#[prost]`?
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -813,24 +815,26 @@ impl SessionContext {
input,
or_replace,
definition,
+ temporary,
} = cmd;
let view = self.table(name.clone()).await;
- match (or_replace, view) {
- (true, Ok(_)) => {
+ match (or_replace, view, temporary) {
+ (_, _, true) => exec_err!("'TEMPORARY' view not defined'"),
Review Comment:
i am unsure if the `exec_err!` here is appropriate, should the temporary
semantics bleed into the execution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
