jonahgao commented on code in PR #13028:
URL: https://github.com/apache/datafusion/pull/13028#discussion_r1808293093
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -623,8 +623,8 @@ pub async fn from_substrait_rel(
from_substrait_rel(ctx, input, extensions).await?,
);
let offset = fetch.offset as usize;
- // Since protobuf can't directly distinguish `None` vs `0`
`None` is encoded as `MAX`
- let count = if fetch.count as usize == usize::MAX {
+ // -1 means that ALL records should be returned
Review Comment:
According to the substrait
[spec](https://github.com/substrait-io/substrait/blob/683f4179a058c2c99c04501b920a48ff372356ff/proto/substrait/algebra.proto#L273),
we should use `-1` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
