jonahgao commented on code in PR #13028:
URL: https://github.com/apache/datafusion/pull/13028#discussion_r1808297266
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1930,16 +1944,20 @@ impl LogicalPlan {
)
}
},
- LogicalPlan::Limit(Limit {
- ref skip,
- ref fetch,
- ..
- }) => {
+ LogicalPlan::Limit(limit) => {
+ // Attempt to display `skip` and `fetch` as literals
if possible, otherwise as expressions.
Review Comment:
Display literals as before to avoid breaking too many tests. Maybe we could
display them in the expr-style through a follow-up PR. For example, `1` ->
`Int64(1)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
